Simple Code Problem is driving me nuts!

neon147 · Apr 28, 2012

Hi, I have a problem with the simplest code imaginable, and it's driving me nuts that I can't work out what's going wrong! All I want is two buttons, one that increments a counter and prints the result on the screen, while the other button decrements the same counter and prints the result on the screen. As far as I can see, the code below should do just that - but what actually happens is that each button increments/decrements the counter variable ONCE ONLY, and further clicks on the button DO NOTHING AT ALL!!! Why do the buttons seem to work once only???? HELP!! ************************************************** ************** THE CODE: ************************************************** ************** <%@ Page Language="VB" Debug="true" %> <script runat="server" > Dim iCounter as Integer Sub Page_Load(obj as Object, e as EventArgs) if iCounter = "" then iCounter = 1 Response.Write("On Page_Load, iCounter has been set to " & iCounter & " ") end if end sub Sub Up(obj as Object, e as EventArgs) iCounter = iCounter + 1 Response.Write("Having just incremented iCounter, it is now set to " & iCounter & " ") end Sub Sub Down(obj as Object, e as EventArgs) iCounter = iCounter - 1 Response.Write("Having just decremented iCounter, it is now set to " & iCounter & " ") end Sub </script> <html><body> <form runat="server" > <asp:Button runat="server" id="btUp" Text="Up" OnClick="Up" /> <asp:Button runat="server" id="btDown" Text="Down" OnClick="Down" /> </form> </body></html>First Thing Web is state less, and your variable iCounter dies whenever that page life expires. in this case you can use hidden text box to store variable value of ICounter. your code would work then. Hi I have made few changes to your code so as to maintain state of application ************************************************** *************** Code ************************************************** *************** <%@ Page Language="VB" Debug="true" %> <script runat="server"> Sub Page_Load(obj as Object, e as EventArgs) if txtcounter.text = "" then txtcounter.text = 1 Response.Write("On Page_Load, iCounter has been set to " & txtcounter.text & " ") end if end sub Sub Up(obj as Object, e as EventArgs) txtcounter.text = cint(txtcounter.text) + 1 Response.Write("Having just incremented iCounter, it is now set to " & txtcounter.text & " ") end Sub Sub Down(obj as Object, e as EventArgs) txtcounter.text = cint(txtcounter.text) - 1 Response.Write("Having just decremented iCounter, it is now set to " & txtcounter.text & " ") end Sub </script> <html> <body> <form runat="server" ID="Form1"> <asp:Button runat="server" id="btUp" Text="Up" OnClick="Up" /> <asp:Button runat="server" id="btDown" Text="Down" OnClick="Down" /> <asp:TextBox Runat="server" ID="txtcounter" visible="False"></asp:TextBox> </form> </body> </html>Hi, there!!! I think it should solve, don't??? Well, it will seem not to work at first time, but what occurs is that the pageload with non-postback is called two times: the first when page loads and the second when you first submits the form... try to improve it and make contact if you can't... <%@ Page Language="VB" Debug="true" %> <script runat="server"> Sub Page_Load(obj as Object, e as EventArgs) If Not IsPostBack Then iCounter.Value = http://aspmessageboard.com/archive/index.php/1 Response.Write("On Page_Load, iCounter has been set to " & iCounter.Value & ".") End If End Sub Sub Up(obj as Object, e as EventArgs) iCounter.Value = iCounter.Value + 1 Response.Write("Having just incremented iCounter.Value, it is now set to " & iCounter.Value & ".") end Sub Sub Down(obj as Object, e as EventArgs) iCounter.Value = iCounter.Value - 1 Response.Write("Having just decremented iCounter.Value, it is now set to " & iCounter.Value & ".") end Sub </script> <html><body> <form runat="server"> <asp:Button runat="server" id="btUp" Text="Up" OnClick="Up" /> <asp:Button runat="server" id="btDown" Text="Down" OnClick="Down" /> <input type=hidden runat=server id=iCounter value=0> </form> </body></html>Thanks for your help, code is now working and the world seems a better place! JON

Simple Code Problem is driving me nuts!

neon147

New Member