Please help me with my bookmark link

I'm using the code below to create a bookmark link on my site. It isn't working and I'm wondering what I need to do to make it work properly. <br />
<br />
I already know I'm supposed to put my url where it says "place url here".<br />
<br />
But Where it says (url,description);am I supposed to put my url there? <br />
<br />
<SCRIPT LANGUAGE="JavaScript"> <br />
function bookmark(url, description)<br />
{<br />
netscape="Netscape User's hit CTRL+D to add a bookmark to this site."<br />
if (navigator.appName=='Microsoft Internet Explorer')<br />
{<br />
window.external.AddFavorite(url, description);<br />
}<br />
else if (navigator.appName=='Netscape')<br />
{<br />
alert(netscape);<br />
}<br />
}<br />
//--> <br />
</SCRIPT> <br />
<br />
<a href=http://www.htmlforums.com/archive/index.php/"javascript:bookmark(' <!-- m --><a class="postlink" href="http://place">http://place</a><!-- m --> url here.com ',' title of site');">Bookmark this Site</A><!--content-->no the url is a variable. all you need to do is change<br />
<br />
<a href=http://www.htmlforums.com/archive/index.php/"java script:bookmark(' <!-- m --><a class="postlink" href="http://place">http://place</a><!-- m --> url here.com ',' title of site');">Bookmark this Site</A><br />
<br />
that to meet your needs. so you would change 'title of site' to your title and then place url here.com to yours. don't mess with an of the script<!--content-->But now I have no idea why it is not working properly because apparantly I'm doing it right based on your answer.<br />
<br />
could extra spaces somewhere make it not work right?<!--content-->sometiems, what error are you getting?<!--content-->When I clicked on the bookmark link instead of bookmarking the page it gives me an error that says:<br />
<br />
window,external is null or is not an object<br />
<br />
I don't know what that means<!--content-->make sure you take out the space next to the ' in this line<br />
<br />
<a href=http://www.htmlforums.com/archive/index.php/"java script:bookmark(' <!-- m --><a class="postlink" href="http://place">http://place</a><!-- m --> url here.com ',' title of site');">Bookmark this Site</A><br />
<br />
<br />
so it should be like so<br />
<br />
<a href=http://www.htmlforums.com/archive/index.php/"java script:bookmark('http://placeurlhere.com','title of site');">Bookmark this Site</A><!--content-->
 
Back
Top