php refactoring and better coding for php?

austers

New Member
i have this process that is the heart of my app, that im creating, but for some reason i feel like its the worst way to do it(instinct) , and i wanted to see if thier is something wrong with this process, and am i approaching it in a bad way! p.s. the code works fine, just refactoring problem.the process is:users go to homepage, they see thier latest activities, by other site memebers(home.php),\[code\] //function to bring the latest activities from database $results=function getUserUpdates($_SESSION['user_id'];while($row = mysql_fetch_array($results)) {//another function to format the activities in a social stream echo formatUpdate($row['user_note'],$row['dt'],$row['picture'],$row['username'],$row['id'],$row['reply_id'],$row['reply_name'],$row['votes_up'],$row['votes_down']); }\[/code\]i have put the function codes in pastie.formatUpdate function http://pastie.org/1213958getUserUpdates function http://pastie.org/1213962EDIT both functions are from different files they are included in home.php,formatUpdate from functions.phpgetUserUpdates from queries.php
 
Back
Top