dadscookies
New Member
I'm using the following PHP MySQL database class. I'm curious as to what I could do to make it more secure. I'm happy with it so far, but without suggesting to "use PDO" what can I do to improve this currently?\[code\] <? class DbConnector { public static function getInstance(){ static $instance = null; if($instance === null){ $instance = new DbConnector(); } return $instance; } var $theQuery; var $link; function DbConnector() { $host = 'localhost'; $db = ''; $user = ''; $pass = ''; // connect to the db $this->link = mysql_connect($host, $user, $pass); mysql_select_db($db); register_shutdown_function(array(&$this, 'close')); } function find($query) { $ret = mysql_query($query, $this->link); if (mysql_num_rows($ret) == 0) return array(); $retArray = array(); while ($row = mysql_fetch_array($ret)) $retArray[] = $row; return $retArray; } function insert($query) { $ret = mysql_query($query, $this->link); if (mysql_affected_rows() < 1) return false; return true; } function query($query) { $this->theQuery = $query; return mysql_query($query, $this->link); } function fetchArray($result) { return mysql_fetch_array($result); } function close() { mysql_close($this->link); } function exists($query) { $ret = mysql_query($query, $this->link); if (mysql_num_rows($ret) == 0) return false; } function last_id($query) { return mysql_insert_id($query); }}?>\[/code\]